reductionista opened a new pull request #426: Update sql.yy for Bison 3 URL: https://github.com/apache/madlib/pull/426 This line: ``` %define "parser_class_name" "SQLParser" ``` in `sql.yy` does not compile in Bison 3.x Putting quotes around the variable being defined has been deprecated since Bison 2.3b (2008). But it is no longer supported at all in the current versions of Bison that you can install with standard package managers. Removing the double quotes around the variable name parser_class_name will allow Bison 3.4 (current version you get by running brew install bison) to compile the madlib docs successfully. Additionally, even without the quotes, the syntax of this line (as well as another in the same file) has been deprecated in recent Bison versions. This part doesn't actually generate errors yet, just warnings. I've updated those in this PR by running "bison --update" on `sql.yy`. This will break backward compatibility and require someone to have at least bison 3.3 to compile the madlib docs. If that's an issue, we can just remove the quotes for now, and postpone the rest until it's actually generating errors.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
