kaknikhil commented on a change in pull request #425: DL: Add training for multiple models URL: https://github.com/apache/madlib/pull/425#discussion_r310263424
########## File path: src/ports/postgres/modules/deep_learning/test/madlib_keras.sql_in ########## @@ -1179,3 +1180,93 @@ SELECT assert( abs(first.training_metrics_final-second.training_metrics[2]) < 1e-10, 'Transfer learning test failed because training loss and metrics don''t match the expected value.') FROM iris_model_first_run AS first, iris_model_transfer_summary AS second; + +-- Multiple models test +DROP TABLE if exists iris_data_packed_dist, iris_data_packed_dist_summary; +CREATE TABLE iris_data_packed_dist AS + SELECT *, (row_number() over())%3 AS dist_key FROM iris_data_packed; +CREATE TABLE iris_data_packed_dist_summary AS SELECT * FROM iris_data_packed_summary; + +DROP TABLE IF EXISTS mst_table; +CREATE TABLE mst_table (mst_key INTEGER, + model_arch_id INTEGER, + compile_params VARCHAR, + fit_params VARCHAR, + unique (model_arch_id, compile_params, fit_params)); +INSERT INTO mst_table(mst_key, + model_arch_id, + compile_params, + fit_params) + VALUES (1, 1, + 'loss=''categorical_crossentropy'', optimizer=''Adam(lr=0.01)'', metrics=[''accuracy'']', + 'batch_size=16, epochs=1'), + (2, 1, + 'loss=''categorical_crossentropy'', optimizer=''Adam(lr=0.001)'', metrics=[''accuracy'']', + 'batch_size=16, epochs=1'), + (3, 1, + 'loss=''categorical_crossentropy'', optimizer=''Adam(lr=0.0001)'', metrics=[''accuracy'']', + 'batch_size=16, epochs=1'); + +CREATE FUNCTION test_mult_models() +RETURNS VOID AS $$ +begin +DROP TABLE if exists iris_multiple_model, iris_multiple_model_summary, iris_multiple_model_info; + +PERFORM madlib_keras_fit_multiple_model( + 'iris_data_packed_dist', + 'iris_multiple_model', + 'iris_model_arch', + 'mst_table', + 2, + 0 +); + Review comment: I think we should add an assert to check for the number of rows in the `iris_multiple_model_info` table. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
