makemebitter commented on a change in pull request #425: DL: Add training for 
multiple models
URL: https://github.com/apache/madlib/pull/425#discussion_r311287982
 
 

 ##########
 File path: src/ports/postgres/modules/deep_learning/madlib_keras.py_in
 ##########
 @@ -557,7 +603,8 @@ def evaluate(schema_madlib, model_table, test_table, 
output_table, gpus_per_host
 
 def get_loss_metric_from_keras_eval(schema_madlib, table, compile_params,
                                     model_arch, serialized_weights, 
gpus_per_host,
-                                    segments_per_host, seg_ids, 
images_per_seg):
+                                    segments_per_host, seg_ids, images_per_seg,
+                                    is_final=True):
 
 Review comment:
   The function is being called from multiple places. Making this parameter 
optional is only to save the hassle of modifying all of them.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to