njayaram2 commented on a change in pull request #430: Add generate mst table utility. URL: https://github.com/apache/madlib/pull/430#discussion_r312198886
########## File path: src/ports/postgres/modules/deep_learning/madlib_keras.sql_in ########## @@ -1750,6 +1750,20 @@ CREATE OR REPLACE FUNCTION MADLIB_SCHEMA.madlib_keras_fit( $$ LANGUAGE sql VOLATILE m4_ifdef(`__HAS_FUNCTION_PROPERTIES__', `MODIFIES SQL DATA'); +CREATE OR REPLACE FUNCTION MADLIB_SCHEMA.madlib_keras_generate_mst_table( + model_selection_table VARCHAR, + model_arch_table VARCHAR, + model_arch_id_list INTEGER[], + compile_params_list VARCHAR[], + fit_params_list VARCHAR[] +) RETURNS VOID AS $$ + PythonFunctionBodyOnly(`deep_learning', `madlib_keras_model_hopper_utilities') + with AOControl(False): + mst_generator = madlib_keras_model_hopper_utilities.GenerateMstTable(**globals()) + mst_generator.generate() +$$ LANGUAGE plpythonu VOLATILE +m4_ifdef(`__HAS_FUNCTION_PROPERTIES__', `MODIFIES SQL DATA', `'); + Review comment: I am wondering if this function (and other param search related functions) should be in a different SQL file itself. Param search will mostly likely be a different tab in our user docs too. `madlib_keras.sql_in` is already big enough, and adding user docs for param search will just make it way bigger. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
