kaknikhil commented on a change in pull request #433: Kmeans: Add automatic optimal cluster estimation URL: https://github.com/apache/madlib/pull/433#discussion_r320494554
########## File path: src/ports/postgres/modules/kmeans/kmeans_auto.py_in ########## @@ -0,0 +1,201 @@ +# coding=utf-8 +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +""" +@file kmeans_auto.py_in + +@brief + +""" + +import numpy as np +import math +import plpy +from utilities.utilities import _assert +from utilities.utilities import unique_string +from utilities.validate_args import output_tbl_valid +from utilities.validate_args import get_algorithm_name + +ELBOW = 'elbow' +SILHOUETTE = 'silhouette' +BOTH = 'both' + +def _validate(output_table, k): + + output_tbl_valid(output_table, "kmeans_auto") + output_tbl_valid(output_table+'_summary', "kmeans_auto") + + _assert(k, "kmeans_auto: k cannot be NULL.") + _assert(len(k)>1, "kmeans_auto: there has to be more than 1 k values to consider.") Review comment: consider rephrasing this to something like `kmeans_auto: Length of k array should be more than 1` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
