kaknikhil commented on a change in pull request #443: DL: Add training for
multiple models
URL: https://github.com/apache/madlib/pull/443#discussion_r326758369
##########
File path:
src/ports/postgres/modules/deep_learning/test/madlib_keras_model_selection.sql_in
##########
@@ -19,39 +19,14 @@
*
*//* ---------------------------------------------------------------------*/
--- MST table generation tests
+m4_include(`SQLCommon.m4')
--- First set up model arch table, to use as input
-DROP TABLE IF EXISTS iris_model_arch;
--- NOTE: The seed is set to 0 for every layer.
-SELECT load_keras_model('iris_model_arch', -- Output table,
-$$
-{
-"class_name": "Sequential",
-"keras_version": "2.1.6",
-"config":
- [{"class_name": "Dense", "config": {"kernel_initializer": {"class_name":
"VarianceScaling",
- "config": {"distribution": "uniform", "scale": 1.0, "seed": 0, "mode":
"fan_avg"}},
- "name": "dense_1", "kernel_constraint": null, "bias_regularizer": null,
- "bias_constraint": null, "dtype": "float32", "activation": "relu",
"trainable": true,
- "kernel_regularizer": null, "bias_initializer": {"class_name": "Zeros",
- "config": {}}, "units": 10, "batch_input_shape": [null, 4], "use_bias":
true,
- "activity_regularizer": null}}, {"class_name": "Dense",
- "config": {"kernel_initializer": {"class_name": "VarianceScaling",
- "config": {"distribution": "uniform", "scale": 1.0, "seed": 0, "mode":
"fan_avg"}},
- "name": "dense_2", "kernel_constraint": null, "bias_regularizer": null,
- "bias_constraint": null, "activation": "relu", "trainable": true,
"kernel_regularizer": null,
- "bias_initializer": {"class_name": "Zeros", "config": {}}, "units": 10,
"use_bias": true,
- "activity_regularizer": null}}, {"class_name": "Dense", "config":
{"kernel_initializer":
- {"class_name": "VarianceScaling", "config": {"distribution": "uniform",
"scale": 1.0,
- "seed": 0, "mode": "fan_avg"}}, "name": "dense_3", "kernel_constraint":
null,
- "bias_regularizer": null, "bias_constraint": null, "activation": "softmax",
- "trainable": true, "kernel_regularizer": null, "bias_initializer":
{"class_name": "Zeros",
- "config": {}}, "units": 3, "use_bias": true, "activity_regularizer":
null}}],
- "backend": "tensorflow"}
-$$
-);
+\i m4_regexp(MODULE_PATHNAME,
+ `\(.*\)libmadlib\.so',
+
`\1../../modules/deep_learning/test/madlib_keras_iris.setup.sql_in'
+)
+-- MST table generation tests
Review comment:
Do we assert anywhere that our model is learning, like we do for keras_fit ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
