kaknikhil commented on a change in pull request #432: MADLIB-1351 : Added stopping criteria on perplexity to LDA URL: https://github.com/apache/madlib/pull/432#discussion_r333279428
########## File path: src/ports/postgres/modules/lda/test/lda.sql_in ########## @@ -438,7 +444,9 @@ select assert(array_upper(perplexity_iters,1) <= 5, 'Perplexity iterations are d select assert(perplexity[1] > 0 , 'Perplexity value should be greate than 0') from lda_model ; --- Test to check if the perplexity_toll is greater than the difference between two perplexity iterations -- +-- Test: If the difference between the last two iterations is less than the perplexity_tol, the iterations training will stop -- Review comment: Instead of saying `last two iterations` we can just say `If the perplexity difference between any two iterations is less than the perplexity_tol, we will stop training.` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
