orhankislal commented on a change in pull request #451: DL: Update evaluate and
predict for multi model outputs
URL: https://github.com/apache/madlib/pull/451#discussion_r337176935
##########
File path:
src/ports/postgres/modules/deep_learning/madlib_keras_fit_multiple_model.py_in
##########
@@ -289,7 +290,7 @@ class FitMultipleModel():
output_table_insert_query_prepared = plpy.prepare(
output_table_insert_query, ["bytea", "json"])
plpy.execute(output_table_insert_query_prepared, [
- serialized_state, json.dumps(model_arch)])
Review comment:
The `model_arch` can be written as is, as can be seen in the regular fit
function. json.dumps was only adding another pair of quotes around it. It
doesn't break this function (it is just recording in the output table) but
created problems down the line (eval and pred).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
