reductionista commented on a change in pull request #462: DL: Add asymmetric 
cluster support for fit and evaluate
URL: https://github.com/apache/madlib/pull/462#discussion_r352951666
 
 

 ##########
 File path: src/ports/postgres/modules/deep_learning/madlib_keras_wrapper.py_in
 ##########
 @@ -56,7 +57,7 @@ def reset_cuda_env(value):
     else:
         del os.environ[CUDA_VISIBLE_DEVICES_KEY]
 
-def get_device_name_and_set_cuda_env(gpus_per_host, seg):
+def get_device_name_and_set_cuda_env_predict(gpus_per_host, seg):
 
 Review comment:
   For predict it is still called `gpus_per_host`, but for fit and evaluate 
it's called `gpus_per_segment`.  Should at least be consistent.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to