orhankislal commented on a change in pull request #462: DL: Add asymmetric
cluster support for fit and evaluate
URL: https://github.com/apache/madlib/pull/462#discussion_r353385598
##########
File path:
src/ports/postgres/modules/deep_learning/madlib_keras_fit_multiple_model.sql_in
##########
@@ -63,11 +63,13 @@ CREATE OR REPLACE FUNCTION
MADLIB_SCHEMA.fit_transition_multiple_model(
model_architecture TEXT,
compile_params TEXT,
fit_params TEXT,
+ dist_key INTEGER,
+ dist_key_mapping INTEGER[],
current_seg_id INTEGER,
- seg_ids INTEGER[],
- images_per_seg INTEGER[],
- gpus_per_host INTEGER,
segments_per_host INTEGER,
+ images_per_seg INTEGER[],
+ use_gpus BOOLEAN,
+ gpus_per_seg INTEGER[],
Review comment:
`gpus_per_seg` means the number of gpus accessible for each segment. I don't
think `gpus_per_host` is a good name in this case. How does
`available_gpus_per_seg` or `accessible_gpus_per_seg` sound?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
