khannaekta commented on a change in pull request #463: DL: Add asymmetric 
cluster check for predict
URL: https://github.com/apache/madlib/pull/463#discussion_r356288052
 
 

 ##########
 File path: src/ports/postgres/modules/deep_learning/madlib_keras_predict.py_in
 ##########
 @@ -41,22 +41,31 @@ from madlib_keras_wrapper import *
 
 class BasePredict():
     def __init__(self, schema_madlib, table_to_validate, test_table, id_col,
-                 independent_varname, output_table, pred_type, gpus_per_host):
+                 independent_varname, output_table, pred_type, use_gpus, 
module_name):
         self.schema_madlib = schema_madlib
         self.table_to_validate = table_to_validate
         self.test_table = test_table
         self.id_col = id_col
         self.independent_varname = independent_varname
         self.output_table = output_table
         self.pred_type = pred_type
-        self.gpus_per_host = gpus_per_host
-        self._set_default_gpus_pred_type()
+        self.module_name = module_name
+
+        self.segments_per_host = get_segments_per_host()
+        self.use_gpus = use_gpus if use_gpus else False
+        if self.use_gpus:
+            accessible_gpus_for_seg = 
get_accessible_gpus_for_seg(schema_madlib, self.segments_per_host, 
self.module_name)
+            _assert(len(set(accessible_gpus_for_seg)) == 1,
+                '{0}: Asymetric gpu configurations are not 
supported'.format(self.module_name))
 
 Review comment:
   Asymetric -> Asymmetric

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to