khannaekta commented on a change in pull request #466: DL: Modify multi-fit
warm start to accept non-matching mst&model tables
URL: https://github.com/apache/madlib/pull/466#discussion_r362952018
##########
File path:
src/ports/postgres/modules/deep_learning/madlib_keras_fit_multiple_model.py_in
##########
@@ -352,6 +353,22 @@ class FitMultipleModel():
metrics_type=metrics_type)
plpy.execute(info_table_insert_query)
+ if not mst['mst_key'] in warm_start_msts:
+ model = model_from_json(model_arch)
+ serialized_state = model_weights if model_weights else \
+
madlib_keras_serializer.serialize_nd_weights(model.get_weights())
Review comment:
I think we don't need to calculate the weights here for non warm_start
mst_keys as we have already calculated it from the model when calling
`get_initial_weights()`. So we can just use `serialized_weights` to insert into
model_output_table.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
