orhankislal commented on a change in pull request #483: Graph: Fix column type
and output table schema bugs
URL: https://github.com/apache/madlib/pull/483#discussion_r387295464
##########
File path: src/ports/postgres/modules/graph/apsp.sql_in
##########
@@ -412,9 +412,9 @@ m4_ifdef(`\_\_HAS_FUNCTION_PROPERTIES\_\_', `MODIFIES SQL
DATA', `');
CREATE OR REPLACE FUNCTION MADLIB_SCHEMA.graph_apsp_get_path(
apsp_table TEXT,
- source_vertex INT,
- dest_vertex INT,
- path_table TEXT
+ source_vertex BIGINT,
Review comment:
Yes, we still have tests that pass integer columns to these functions that
work as expected.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services