orhankislal commented on a change in pull request #485: DL: Remove fit final
multiple and improve serialization of image_count+weights
URL: https://github.com/apache/madlib/pull/485#discussion_r387904592
##########
File path:
src/ports/postgres/modules/deep_learning/madlib_keras_fit_multiple_model.sql_in
##########
@@ -1537,6 +1537,5 @@ CREATE AGGREGATE MADLIB_SCHEMA.fit_step_multiple_model(
/* is_final_iteration */ BOOLEAN
)(
STYPE=BYTEA,
- SFUNC=MADLIB_SCHEMA.fit_transition_multiple_model,
- FINALFUNC=MADLIB_SCHEMA.fit_final_multiple_model
Review comment:
It seems the sql and python functions for `fit_final_multiple_model` are
still in code even though we don't call them anymore. Is there a particular
reason for keeping them?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
