orhankislal commented on a change in pull request #482: Added support for 
quoted identifiers for install-check
URL: https://github.com/apache/madlib/pull/482#discussion_r388455960
 
 

 ##########
 File path: src/madpack/madpack.py
 ##########
 @@ -674,7 +674,6 @@ def _process_py_sql_files_in_modules(modset, args_dict):
 
         # Loop through all SQL files for this module
         source_files = glob.glob(mask)
-        source_files = [s for s in source_files if '.setup' not in s]
 
 Review comment:
   No worries, I removed this line before merging the code. Thanks for the PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to