fmcquillan99 commented on pull request #501:
URL: https://github.com/apache/madlib/pull/501#issuecomment-634352089


   (1) 
   should throw error if specify custom functions but do not specify an object 
table
   
   ```
   DROP TABLE IF EXISTS mst_table, mst_table_summary;
   
   SELECT madlib.load_model_selection_table('model_arch_library', -- model 
architecture table
                                            'mst_table',          -- model 
selection table output
                                             ARRAY[1,2],              -- model 
ids from model architecture table
                                             ARRAY[                   -- 
compile params
                                                 
$$loss=sum_fn,optimizer='Adam(lr=0.1)',metrics=['accuracy']$$,
                                                 $$loss=mult_fn, 
optimizer='Adam(lr=0.01)',metrics=['accuracy']$$,
                                                 
$$loss='categorical_crossentropy',optimizer='Adam(lr=0.001)',metrics=['accuracy']$$
                                             ],
                                             ARRAY[                    -- fit 
params
                                                 $$batch_size=4,epochs=1$$,
                                                 $$batch_size=8,epochs=1$$
                                             ]
                                            );
   
    load_model_selection_table 
   ----------------------------
   
   (1 row)
   ```
   produces
   ```
   select * from mst_table;
   
    mst_key | model_id |                                 compile_params         
                         |      fit_params       
   
---------+----------+---------------------------------------------------------------------------------+-----------------------
          3 |        1 | loss=mult_fn, 
optimizer='Adam(lr=0.01)',metrics=['accuracy']                    | 
batch_size=4,epochs=1
          4 |        1 | loss=mult_fn, 
optimizer='Adam(lr=0.01)',metrics=['accuracy']                    | 
batch_size=8,epochs=1
          7 |        2 | 
loss='categorical_crossentropy',optimizer='Adam(lr=0.001)',metrics=['accuracy'] 
| batch_size=4,epochs=1
          8 |        2 | 
loss='categorical_crossentropy',optimizer='Adam(lr=0.001)',metrics=['accuracy'] 
| batch_size=8,epochs=1
         11 |        2 | 
loss=sum_fn,optimizer='Adam(lr=0.1)',metrics=['accuracy']                       
| batch_size=4,epochs=1
         12 |        2 | 
loss=sum_fn,optimizer='Adam(lr=0.1)',metrics=['accuracy']                       
| batch_size=8,epochs=1
          1 |        1 | 
loss='categorical_crossentropy',optimizer='Adam(lr=0.001)',metrics=['accuracy'] 
| batch_size=4,epochs=1
          2 |        1 | 
loss='categorical_crossentropy',optimizer='Adam(lr=0.001)',metrics=['accuracy'] 
| batch_size=8,epochs=1
          5 |        1 | 
loss=sum_fn,optimizer='Adam(lr=0.1)',metrics=['accuracy']                       
| batch_size=4,epochs=1
          6 |        1 | 
loss=sum_fn,optimizer='Adam(lr=0.1)',metrics=['accuracy']                       
| batch_size=8,epochs=1
          9 |        2 | loss=mult_fn, 
optimizer='Adam(lr=0.01)',metrics=['accuracy']                    | 
batch_size=4,epochs=1
         10 |        2 | loss=mult_fn, 
optimizer='Adam(lr=0.01)',metrics=['accuracy']                    | 
batch_size=8,epochs=1
   (12 rows)
   ```
   and
   ```
   select * from mst_table_summary;
   
     model_arch_table  | object_table 
   --------------------+--------------
    model_arch_library | 
   (1 row)
   ```
   
   Maybe we should add a test for this.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to