fmcquillan99 edited a comment on pull request #528:
URL: https://github.com/apache/madlib/pull/528#issuecomment-761292406


   (1)
   master shows bug
   ```
   DROP TABLE IF EXISTS automl_output, automl_output_info, 
automl_output_summary, automl_mst_table, automl_mst_table_summary;
   
   SELECT madlib.madlib_keras_automl('iris_train_packed',                -- 
source table
                                     'automl_output',                    -- 
model output table
                                     'model_arch_library',               -- 
model architecture table
                                     'automl_mst_table',                 -- 
model selection output table
                                     ARRAY[1,2],                         -- 
model IDs
                                     $${
                                         'loss': ['categorical_crossentropy'], 
                                         'optimizer_params_list': [ 
                                             {'optimizer': ['Adam'],'lr': 
[0.001, 0.1, 'log']},
                                             {'optimizer': ['RMSprop'],'lr': 
[0.001, 0.1, 'log']}
                                         ],
                                         'metrics': ['accuracy']
                                     } $$,                               -- 
compile param grid
                                     $${'batch_size': [4, 8], 'epochs': [1]}$$, 
 -- fit params grid
                                     'hyperband',                        -- 
autoML method
                                     'R=9, eta=3, skip_last=0',          -- 
autoML params
                                     NULL,                               -- 
random state
                                     NULL,                               -- 
object table
                                     FALSE,                              -- use 
GPUs
                                     'iris_test_packed',                 -- 
validation table
                                     1,                                  -- 
metrics compute freq
                                     NULL,                               -- name
                                     NULL);                              -- 
descr
   select mst_key, metrics_iters, metrics_elapsed_time from automl_output_info 
order by mst_key, metrics_iters;
   
    mst_key |          metrics_iters          |                                 
                                                                    
metrics_elapsed_time                                                            
                                          
   
---------+---------------------------------+-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
          1 | {1}                             | {11.9657690525055}
          2 | {1,2,3,4}                       | 
{11.2435529232025,7.15870094299316,13.9523301124573,20.7438840866089}
          3 | {1}                             | {11.0448019504547}
          4 | {1}                             | {10.6117079257965}
          5 | {1}                             | {11.5615530014038}
          6 | {1}                             | {12.3658618927002}
          7 | {1,2,3,4,5,6,7,8,9,10,11,12,13} | 
{12.1693890094757,6.33618497848511,13.3471310138702,20.1482579708099,6.07377481460571,12.4327578544617,18.6241388320923,24.763916015625,31.0342478752136,37.2289469242096,43.5491759777069,49.7643358707428,55.9758470058441}
          8 | {1,2,3,4}                       | 
{11.7585899829865,6.14086508750916,13.1444580554962,19.9498901367188}
          9 | {1}                             | {10.8477530479431}
         10 | {2,3,4}                         | 
{6.53312110900879,13.5493569374084,20.3438241481781}
         11 | {2,3,4,5,6,7,8,9,10,11,12,13}   | 
{5.94354104995728,12.804829120636,19.7415940761566,5.19919085502625,11.5645568370819,17.7508308887482,23.8869698047638,30.0048508644104,36.2117488384247,42.4137489795685,48.7213318347931,54.9328229427338}
         12 | {2,3,4}                         | 
{6.87433815002441,13.7501399517059,20.5427489280701}
         13 | {5,6,7,8,9,10,11,12,13}         | 
{5.63267993927002,11.9994189739227,18.1830978393555,24.3246037960052,30.4504268169403,36.6406087875366,43.0894849300385,49.3178629875183,55.5346329212189}
         14 | {5,6,7,8,9,10,11,12,13}         | 
{5.43539190292358,11.8002669811249,17.9837338924408,24.1173579692841,30.2419698238373,36.4428617954254,42.7420439720154,48.9511477947235,55.3243119716644}
         15 | {5,6,7,8,9,10,11,12,13}         | 
{5.8685348033905,12.2334108352661,18.4217088222504,24.5603718757629,30.6826229095459,37.0211157798767,43.3373968601227,49.5628578662872,55.7701609134674}
   (15 rows)
   ```
   
   (2)
   PR528 shows bug fixed
   ```
    mst_key |          metrics_iters          |                                 
                                                                   
metrics_elapsed_time                                                            
                                         
   
---------+---------------------------------+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
          1 | {1,2,3,4}                       | 
{12.2509210109711,21.5696251392365,28.4033880233765,35.4542641639709}
          2 | {1,2,3,4}                       | 
{11.6164019107819,20.9570059776306,27.7901480197906,34.7061359882355}
          3 | {1}                             | {11.4122948646545}
          4 | {1}                             | {10.8533229827881}
          5 | {1}                             | {11.8194739818573}
          6 | {1}                             | {12.749902009964}
          7 | {1}                             | {12.5533349514008}
          8 | {1}                             | {12.0531778335571}
          9 | {1,2,3,4,5,6,7,8,9,10,11,12,13} | 
{11.1789879798889,20.6207029819489,27.5885601043701,34.508040189743,42.3414781093597,48.0012261867523,53.787230014801,59.5213670730591,65.2600991725922,71.2501010894775,76.8915431499481,82.5639650821686,88.264790058136}
         10 | {2,3,4}                         | 
{21.1628739833832,27.9904689788818,34.9025909900665}
         11 | {2,3,4}                         | 
{20.3932030200958,27.3551881313324,34.2683320045471}
         12 | {2,3,4,5,6,7,8,9,10,11,12,13}   | 
{21.3696491718292,28.1980810165405,35.1015841960907,41.3438279628754,47.1330029964447,52.8797709941864,58.6085150241852,64.4296791553497,70.1329569816589,76.0616669654846,81.7249631881714,87.3962721824646}
         13 | {5,6,7,8,9,10,11,12,13}         | 
{41.7541899681091,47.5591380596161,53.3572280406952,59.0166201591492,64.8324210643768,70.6048891544342,76.4613320827484,82.1320309638977,87.8146560192108}
         14 | {5,6,7,8,9,10,11,12,13}         | 
{41.5514280796051,47.3472530841827,53.1601960659027,58.8155200481415,64.6345729827881,70.4008929729462,76.2625350952148,81.9320771694183,87.6032180786133}
         15 | {5,6,7,8,9,10,11,12,13}         | 
{41.9598820209503,47.7600600719452,53.5559930801392,59.2904281616211,65.0303740501404,70.910637140274,76.6586999893188,82.3321261405945,88.0252130031586}
   (15 rows)
   ```
   
   LGTM


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to