kaknikhil commented on a change in pull request #525:
URL: https://github.com/apache/madlib/pull/525#discussion_r560537577
##########
File path: src/ports/postgres/modules/deep_learning/madlib_keras.sql_in
##########
@@ -1793,13 +1793,23 @@ CREATE OR REPLACE FUNCTION MADLIB_SCHEMA.fit_transition(
segments_per_host INTEGER,
images_per_seg INTEGER[],
use_gpus BOOLEAN,
- accessible_gpus_for_seg INTEGER[],
+ accessible_gpus_for_seg INTEGER[],
prev_serialized_weights BYTEA,
is_final_iteration BOOLEAN,
- custom_function_map BYTEA
+ custom_function_map BYTEA
) RETURNS BYTEA AS $$
PythonFunctionBodyOnlyNoSchema(`deep_learning', `madlib_keras')
- return madlib_keras.fit_transition(**globals())
+ import traceback
+ from sys import exc_info
+ import plpy
+ try:
+ return madlib_keras.fit_transition(**globals())
+ except Exception as e:
+ etype, _, tb = exc_info()
+ detail = ''.join(traceback.format_exception(etype, e, tb))
+ message = e.args[0] + 'TransAggDetail' + detail
Review comment:
Good suggestions, I think we should take care of this in a future PR.
This looks good for now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
