fmcquillan99 commented on pull request #530: URL: https://github.com/apache/madlib/pull/530#issuecomment-763279085
tested for functionality (not performance diff) and seems fine.
Not sure if this is the error message you intend:
```
madlib=# SELECT madlib.madlib_keras_automl('iris_train_packed',
-- source table
madlib(# 'automl_output',
-- model output table
madlib(# 'model_arch_library',
-- model architecture table
madlib(# 'automl_mst_table',
-- model selection output table
madlib(# ARRAY[1,2],
-- model IDs
madlib(# $${
madlib$# 'loss':
['categorical_crossentropy'],
madlib$# 'optimizer_params_list': [
madlib$# {'optimizer':
['Adam'],'lr': [0.001, 0.1, 'log']},
madlib$# {'optimizer':
['RMSprop'],'lr': [0.001, 0.1, 'log']}
madlib$# ],
madlib$# 'metrics': ['accuracy']
madlib$# } $$,
-- compile param grid
madlib(# $${'batch_size': [4, 8],
'epochs': [1]}$$, -- fit params grid
madlib(# 'hyperband',
-- autoML method
madlib(# 'R=9, eta=3, skip_last=1',
-- autoML params
madlib(# NULL,
-- random state
madlib(# NULL,
-- object table
madlib(# FALSE,
-- use GPUs
madlib(# 'iris_test_packed',
-- validation table
madlib(# 1,
-- metrics compute freq
madlib(# NULL,
-- name
madlib(# NULL, --
descr
madlib(# xxx);
-- caching
ERROR: column "xxx" does not exist
LINE 24: xxx);
^
```
This error message seems fine though:
```
madlib=#
madlib=#
madlib=# SELECT madlib.madlib_keras_automl('iris_train_packed',
-- source table
madlib(# 'automl_output',
-- model output table
madlib(# 'model_arch_library',
-- model architecture table
madlib(# 'automl_mst_table',
-- model selection output table
madlib(# ARRAY[1,2],
-- model IDs
madlib(# $${
madlib$# 'loss':
['categorical_crossentropy'],
madlib$# 'optimizer_params_list': [
madlib$# {'optimizer':
['Adam'],'lr': [0.001, 0.1, 'log']},
madlib$# {'optimizer':
['RMSprop'],'lr': [0.001, 0.1, 'log']}
madlib$# ],
madlib$# 'metrics': ['accuracy']
madlib$# } $$,
-- compile param grid
madlib(# $${'batch_size': [4, 8],
'epochs': [1]}$$, -- fit params grid
madlib(# 'hyperband',
-- autoML method
madlib(# 'R=9, eta=3, skip_last=1',
-- autoML params
madlib(# NULL,
-- random state
madlib(# NULL,
-- object table
madlib(# FALSE,
-- use GPUs
madlib(# 'iris_test_packed',
-- validation table
madlib(# 1,
-- metrics compute freq
madlib(# NULL,
-- name
madlib(# NULL,
-- descr
madlib(# 'xxx');
-- caching
ERROR: invalid input syntax for type boolean: "xxx"
LINE 24: 'xxx');
^
```
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
