orhankislal commented on a change in pull request #536:
URL: https://github.com/apache/madlib/pull/536#discussion_r569509775
##########
File path: src/ports/postgres/modules/deep_learning/madlib_keras.py_in
##########
@@ -922,11 +895,14 @@ def evaluate(schema_madlib, model_table, test_table,
output_table,
custom_fn_list = get_custom_functions_list(res['compile_params'])
custom_function_map = query_custom_functions_map(object_table,
custom_fn_list)
- dist_key_mapping, images_per_seg =
get_image_count_per_seg_for_minibatched_data_from_db(test_table,
columns_dict['ind_shape_cols'][0])
+ #TODO should this be indep_varname or dep_varname or either one works ?
Review comment:
The old code used dependent varname but either one works AFAIK.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
