orhankislal commented on a change in pull request #524: URL: https://github.com/apache/madlib/pull/524#discussion_r583642048
########## File path: src/ports/postgres/modules/deep_learning/madlib_keras_wrapper.py_in ########## @@ -309,6 +311,8 @@ def parse_and_validate_fit_params(fit_param_str): literal_eval_fit_params, accepted_fit_params) if 'callbacks' in fit_params_dict: + if not is_superuser(current_user()): Review comment: Both of those are direct SQL queries, neither unit-test nor dev-check is equipped to deal with this, we'll need a different solution to test a non-admin user. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org