khannaekta commented on a change in pull request #571:
URL: https://github.com/apache/madlib/pull/571#discussion_r710331660
##########
File path: src/ports/postgres/modules/dbscan/dbscan.py_in
##########
@@ -164,76 +274,1271 @@ def dbscan(schema_madlib, source_table, output_table,
id_column, expr_point, eps
""".format(**locals())
plpy.execute(sql)
+ # -- Generate output summary table ---
+
output_summary_table = add_postfix(output_table, '_summary')
- plpy.execute("DROP TABLE IF EXISTS {0}".format(output_summary_table))
+ plpy.execute("DROP TABLE IF EXISTS {0}".format(output_summary_table))
sql = """
CREATE TABLE {output_summary_table} AS
SELECT '{id_column}'::VARCHAR AS id_column,
+ '{expr_point}'::VARCHAR AS expr_point,
{eps}::DOUBLE PRECISION AS eps,
+ {min_samples}::BIGINT AS min_points,
Review comment:
The only reason I added this was when I ran it with default values, I
wasn't sure that it ran with `optimized`/`brute_force`.
I think it's ok for now, let's see if we have any ask for it in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@madlib.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
