kaknikhil commented on a change in pull request #574:
URL: https://github.com/apache/madlib/pull/574#discussion_r763467209
##########
File path: src/madpack/madpack.py
##########
@@ -1274,6 +1283,44 @@ def get_madlib_operator_drop_str(schema):
schema, i['name'], i['left_op'], i['right_op'])
return drop_str
+def find_madlib_library_path():
+
+ global madlib_library_path
+ # Local build at ~/workspace/madlib/build/
+ if os.path.isfile(maddir + "/../src/ports/" + portid + "/" + dbver +
+ "/lib/libmadlib.so"):
+ madlib_library_path = maddir + "/../src/ports/" + portid + "/" + dbver
+ \
+ "/lib"
+
+ # Package build at /usr/local/madlib/Versions or $GPHOME/madlib/Versions
+ elif os.path.isfile(maddir + "/../../Current/ports/" + portid + "/" +
dbver +
+ "/lib/libmadlib.so"):
+ madlib_library_path = maddir + "/../../Current/ports/" + portid + "/"
+ dbver + \
+ "/lib"
+ else:
+ madlib_library_path = maddir + "/lib"
+
+def set_dynamic_library_path_in_database(dbver_split):
+
+ global dynamic_library_path
Review comment:
Do we still need this and `madlib_library_path` to be global variables ?
find_madlib_library_path can return `madlib_library_path` which can then be
used by `set_dynamic_library_path_in_database`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@madlib.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
