kaknikhil commented on code in PR #592: URL: https://github.com/apache/madlib/pull/592#discussion_r1114938872
########## src/ports/postgres/modules/graph/test/sssp.sql_in: ########## @@ -280,9 +280,46 @@ INSERT INTO e VALUES (ascii('s'), ascii('t'), 6), (ascii('s'), ascii('y'), 7); -select graph_sssp('v', +CREATE TABLE e_grp(src INT, dest INT, weight float8, grp INT); Review Comment: I think might be a good idea to add a test case for an actual negative cycle to make sure we didn’t add any regression for detecting negative cycles -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@madlib.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org