higuoxing opened a new pull request, #612:
URL: https://github.com/apache/madlib/pull/612
This patch fixes 2 compilation errors:
1. Incomplete type: forget to include the header file `<array>`
```
/home/v/workspace/madlib/src/ports/greenplum/dbconnector/../../postgres/dbconnector/Allocator_impl.hpp:78:50:
error: 'std::array<long unsigned int, 1> numElements' has incomplete type
78 | std::array<std::size_t, BOOST_PP_INC(n)> numElements = {{ \
| ^~~~~~~~~~~
```
2. `snprintf` gets expanded to `pg_snprintf` in PostgreSQL/Greenplum.
```
In file included from
/home/v/.local/gpdb7/include/postgresql/server/c.h:1330,
from
/home/v/.local/gpdb7/include/postgresql/server/postgres.h:46,
from
/home/v/workspace/madlib/src/ports/greenplum/dbconnector/dbconnector.hpp:16:
/usr/include/boost/assert/source_location.hpp: In member function
'std::string boost::source_location::to_string() const':
/usr/include/boost/assert/source_location.hpp:97:9: error: 'pg_snprintf' is
not a member of 'std'; did you mean 'vsnprintf'?
97 | BOOST_ASSERT_SNPRINTF( buffer, ":%lu", ln );
| ^~~~~~~~~~~~~~~~~~~~~
/usr/include/boost/assert/source_location.hpp:104:13: error: 'pg_snprintf'
is not a member of 'std'; did you mean 'vsnprintf'?
104 | BOOST_ASSERT_SNPRINTF( buffer, ":%lu", co );
| ^~~~~~~~~~~~~~~~~~~~~
```
<!--
Thanks for sending a pull request! Here are some tips for you:
1. Refer to this link for contribution guidelines
https://cwiki.apache.org/confluence/display/MADLIB/Contribution+Guidelines
2. Please Provide the Module Name, a JIRA Number and a short description
about your changes.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@madlib.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
