Github user iyerr3 commented on a diff in the pull request:
https://github.com/apache/incubator-madlib/pull/1#discussion_r44072383
--- Diff: src/modules/convex/linear_svm_igd.cpp ---
@@ -152,9 +144,18 @@ linear_svm_igd_final::run(AnyType &args) {
// Aggregates that haven't seen any data just return Null.
if (state.algo.numRows == 0) { return Null(); }
+
--- End diff --
Same as above - I would prefer to have one `if (isL2)` that decides between
the L2 and L1 functions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
