GitHub user orhankislal opened a pull request:
https://github.com/apache/incubator-madlib/pull/13
Bugfix/kmeans null handling
JIRA: MADLIB-946
Closest column used to throw exception if the matrix or the vector argument
had any null values. Changed to return Null() in this case.
Inserted an additional check for null values in the compute_kmeans function
to accomodate for the change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/orhankislal/incubator-madlib
bugfix/kmeans_null_handling
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-madlib/pull/13.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #13
----
commit 57fa0093be32973a2be007daae8b2e06f5ff5d54
Author: Orhan Kislal <[email protected]>
Date: 2016-01-19T22:01:45Z
Null handling in kmeans
MADLIB-946
commit 9984b8d564501b3751ce9199804502723e4f888f
Author: Orhan Kislal <[email protected]>
Date: 2016-01-20T00:36:42Z
Summary: Null handling in kmeans
JIRA: MADLIB-946
commit e79995fef475a6d8847683968a380c0aa331bbed
Author: Orhan Kislal <[email protected]>
Date: 2016-01-20T17:54:34Z
Summary: Null handling in kmeans
JIRA: MADLIB-946
Closest column used to throw exception if the matrix or the vector argument
had any null values. Changed to return Null() in this case.
Inserted an additional check for null values in the compute_kmeans function
to accomodate for the change.
commit 9928f61035d4a1b4fcd87d156ac5f784aafb90bb
Author: Orhan Kislal <[email protected]>
Date: 2016-01-20T18:00:09Z
Summary: Null handling in kmeans
JIRA: MADLIB-946
Closest column used to throw exception if the matrix or the vector argument
had any null values. Changed to return Null() in this case.
Inserted an additional check for null values in the compute_kmeans function
to accomodate for the change
commit 989c652634ea2a1a39ea5ecb54a4395547db926d
Author: Orhan Kislal <[email protected]>
Date: 2016-01-20T23:38:52Z
Summary: Null handling in kmeans
JIRA: MADLIB-946
Closest column used to throw exception if the matrix or the vector argument
had any null values. Changed to return Null() in this case.
Inserted an additional check for null values in the compute_kmeans function
to accomodate for the change.
commit c3f70a8f824772c40be98f7bf415618150eadafa
Author: Orhan Kislal <[email protected]>
Date: 2016-01-21T20:54:03Z
Change in test file
commit e71278e20f6a2b59662a893970423cde5b66e1df
Author: Orhan Kislal <[email protected]>
Date: 2016-01-21T21:19:59Z
Add the test back without any null value to test on gp.
commit c900da73908299499283142a22b847b16b9a803a
Author: Orhan Kislal <[email protected]>
Date: 2016-01-21T22:59:47Z
Change in kmeans test. Removed the function call, only table creation
remains.
commit ca1262b14aeb55a7921c84ed4d67cd2f4d0b9de6
Author: Orhan Kislal <[email protected]>
Date: 2016-01-21T23:25:54Z
Changed the kmeans test to include kmeanspp but omit closest columns calls.
commit 101dad63b09c3186d6046de97f2c851b0aa636c0
Author: Orhan Kislal <[email protected]>
Date: 2016-01-21T23:44:02Z
Kmeans test with fixed file types
commit f4d5eae1033942dd6f4b40ff6a1a3c10da0b837a
Author: Orhan Kislal <[email protected]>
Date: 2016-01-22T00:16:13Z
Removed "madlib." from function call
commit b0496c97fdbd2df0465d3e2b51ad45501f481d94
Author: Orhan Kislal <[email protected]>
Date: 2016-01-22T00:52:51Z
Added null back to the data to test.
commit cc3129a7292f0e6047593d34c0f48c9dee9d722c
Author: Orhan Kislal <[email protected]>
Date: 2016-01-22T01:07:00Z
Added hawq related keywords
commit f8614276841a70a1205a4083e165988d23c9c44b
Author: Orhan Kislal <[email protected]>
Date: 2016-01-22T17:24:28Z
Back to basics example from the wiki
commit d72045cae3c9a839b509c4d0e04304abc7b55586
Author: Orhan Kislal <[email protected]>
Date: 2016-01-22T18:00:05Z
Changed the test to reuse the old dataset
commit c31899a39483e752471c2cba085092008bb43117
Author: Orhan Kislal <[email protected]>
Date: 2016-01-22T18:24:31Z
Changed madlib to {schema_madlib}
commit a2cf6f14f42385b33736e6c0cedc4bca7e83548c
Author: Orhan Kislal <[email protected]>
Date: 2016-01-22T18:42:15Z
Changed the test with Rahul
commit fc93112c77beff1700ca452696c950f62be86205
Author: Orhan Kislal <[email protected]>
Date: 2016-01-19T22:01:45Z
Null handling in kmeans
MADLIB-946
commit bd7b2f47bde3557a8250ca293314a59ac95df6ff
Author: Orhan Kislal <[email protected]>
Date: 2016-01-20T00:36:42Z
Summary: Null handling in kmeans
JIRA: MADLIB-946
commit 5bea46274dcc829674ca9cb26d7d2b820aa1c624
Author: Orhan Kislal <[email protected]>
Date: 2016-01-20T17:54:34Z
Summary: Null handling in kmeans
JIRA: MADLIB-946
Closest column used to throw exception if the matrix or the vector argument
had any null values. Changed to return Null() in this case.
Inserted an additional check for null values in the compute_kmeans function
to accomodate for the change.
commit b318c4ee16f63df77ed9d2854b8a57ef0703d420
Author: Orhan Kislal <[email protected]>
Date: 2016-01-20T18:00:09Z
Summary: Null handling in kmeans
JIRA: MADLIB-946
Closest column used to throw exception if the matrix or the vector argument
had any null values. Changed to return Null() in this case.
Inserted an additional check for null values in the compute_kmeans function
to accomodate for the change
commit 76c01ef533b171555b837d084a28297e2a4b2176
Author: Orhan Kislal <[email protected]>
Date: 2016-01-20T23:38:52Z
Summary: Null handling in kmeans
JIRA: MADLIB-946
Closest column used to throw exception if the matrix or the vector argument
had any null values. Changed to return Null() in this case.
Inserted an additional check for null values in the compute_kmeans function
to accomodate for the change.
commit 3e41cb9cd8c884353aa6f2d1516eda7ecd686be0
Author: Orhan Kislal <[email protected]>
Date: 2016-01-21T20:54:03Z
Change in test file
commit ece79cdace9e511c61b7281e8885320c2d6bc323
Author: Orhan Kislal <[email protected]>
Date: 2016-01-21T21:19:59Z
Add the test back without any null value to test on gp.
commit 33d20db8127f92321e090be46976712c30f1b90e
Author: Orhan Kislal <[email protected]>
Date: 2016-01-21T22:59:47Z
Change in kmeans test. Removed the function call, only table creation
remains.
commit 90261645261ff1519195e42c9133416b8e816341
Author: Orhan Kislal <[email protected]>
Date: 2016-01-21T23:25:54Z
Changed the kmeans test to include kmeanspp but omit closest columns calls.
commit 69902aaadf9a29b832285cf84f2f9293f061739e
Author: Orhan Kislal <[email protected]>
Date: 2016-01-21T23:44:02Z
Kmeans test with fixed file types
commit f318aecdbd092ad05e27c4e8e8e00dd5f4cd41f0
Author: Orhan Kislal <[email protected]>
Date: 2016-01-22T00:16:13Z
Removed "madlib." from function call
commit 61ebbceb8ce2936de6d89b299d27c37830a9af7c
Author: Orhan Kislal <[email protected]>
Date: 2016-01-22T00:52:51Z
Added null back to the data to test.
commit 46b144c308960d66feedb9b2984b56361b082467
Author: Orhan Kislal <[email protected]>
Date: 2016-01-22T01:07:00Z
Added hawq related keywords
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
