Github user iyerr3 commented on a diff in the pull request:
https://github.com/apache/incubator-madlib/pull/29#discussion_r57411341
--- Diff: src/ports/postgres/modules/utilities/path.py_in ---
@@ -108,8 +107,11 @@ def path(schema_madlib, source_table, output_table,
partition_expr,
*,
nextval('{seq_gen}') AS {id_col_name},
--- End diff --
you're right. doing a quick test:
```
select count(*) from (select nextval('seq_test') as id from
generate_series(1, 10000000)) q;
Time: 11975.435 ms
select count(*) from (select row_number() over() as id from
generate_series(1, 10000000)) q;
Time: 5716.938 ms
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
