GitHub user orhankislal opened a pull request:
https://github.com/apache/incubator-madlib/pull/39
Random Forest: Fix filtered feature related bug
JIRA: MADLIB-928
Additional Author: Nandish Jayaram <[email protected]>
Random forest filters out a feature if it has the same value for every
row. If grouping is enabled, this filer is applied per group. However
_get_bins_grps function did not consider a case where different groups
have different feature sets. The commit fixes this issue, adds a test
for install-check to replicate the use case and fixes a typo in one of
the related functions.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/orhankislal/incubator-madlib
bugfix/random_forest3
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-madlib/pull/39.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #39
----
commit 1b75152b1245f11b6aa449b4e84189468b40e92d
Author: Orhan Kislal <[email protected]>
Date: 2016-04-06T21:07:26Z
Random Forest: Fix filtered feature related bug
JIRA: MADLIB-928
Additional Author: Nandish Jayaram <[email protected]>
Random forest filters out a feature if it has the same value for every
row. If grouping is enabled, this filer is applied per group. However
_get_bins_grps function did not consider a case where different groups
have different feature sets. The commit fixes this issue, adds a test
for install-check to replicate the use case and fixes a typo in one of
the related functions.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
