Github user orhankislal commented on a diff in the pull request:

    https://github.com/apache/incubator-madlib/pull/65#discussion_r75954265
  
    --- Diff: src/ports/postgres/modules/utilities/test/pivot.sql_in ---
    @@ -152,15 +152,19 @@ SELECT assert(__p_7__ = 1.5,
        'Wrong output in pivoting: Output dictionary') FROM pivout 
        WHERE id = 0 AND id2 = 0;
     
    -DROP AGGREGATE IF EXISTS array_accum (anyelement);
    -CREATE AGGREGATE array_accum (anyelement)
    -(
    -    sfunc = array_append,
    +DROP FUNCTION IF EXISTS array_add1(ANYARRAY, ANYELEMENT);
    +DROP AGGREGATE IF EXISTS array_accum1 (anyelement);
    +CREATE FUNCTION array_add1(ANYARRAY, ANYELEMENT) RETURNS ANYARRAY AS $$
    +  SELECT $1 || $2
    +$$ LANGUAGE sql STRICT;
    --- End diff --
    
    I still appreciate the pointer. This test exists to ensure user defined 
aggregates work with pivoting in addition to the built-in ones. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to