I think that is the safest approach, to create a new RC. Let us cancel the vote on RC-1 and when RC-2 is posted, I will call for a new vote
Thank you Satoshi for catching this. Frank On Fri, Sep 2, 2016 at 8:51 AM, Orhan Kislal <[email protected]> wrote: > I am not an apache veteran but I think it should be a new RC. Here is a > passage from the apache release best practices website. > > Modifications > Once an artifact has been uploaded, it must never be modified. Not only is > there no guarantee that the modified artifact will be correctly archived or > mirrored but a change to an existing artifact is the signature of an > attack. > > Orhan > > On Fri, Sep 2, 2016 at 8:39 AM, Rahul Iyer <[email protected]> wrote: > > > Hi Satoshi, > > > > Thanks for trying the RC and discovering the issue. The '._' files were > > sneaked in by osx during the packaging - I'll create a new RC and upload > > that in a few minutes. > > > > @apache-veterans: Should this be uploaded as a new RC or just update the > > existing RC and signature files? > > > > - Rahul > > > > On Fri, Sep 2, 2016 at 7:05 AM, Satoshi Nagayasu <[email protected]> > wrote: > > > > > Hi Frank, > > > > > > Running "find . | fgrep /._ | xargs rm" before building fixes the build > > > error, > > > so I think those binary files must be removed before the official > > release. > > > > > > Regards, > > > > > > > > > 2016-09-02 22:14 GMT+09:00 Satoshi Nagayasu <[email protected]>: > > > > Frank, > > > > > > > > I have tried to build RC1 from the tarball, and I have a question. > > > > > > > > I got a build error when building on CentOS 6.6 as below. > > > > > > > > [snaga@localhost build]$ env LANG=C make > > > > [ 0%] Built target EP_boost > > > > [ 1%] Built target EP_eigen > > > > [ 1%] Built target EP_pyxb > > > > [ 1%] Built target pythonFiles > > > > [ 1%] Built target sqlFiles > > > > [ 1%] Built target madlibPatches > > > > [ 5%] Built target madpackFiles > > > > [ 5%] Built target binaryFiles > > > > [ 7%] Built target configFiles > > > > [ 28%] Built target sqlFiles_postgresql > > > > [ 28%] Building CXX object > > > > src/ports/postgres/9.6/CMakeFiles/madlib_postgresql_ > > > 9_6.dir/__/__/__/modules/tsa/._arima.cpp.o > > > > /home/snaga/madlib/apache-madlib-1.9.1-incubating- > > > source/src/modules/tsa/._arima.cpp:1:1: > > > > warning: null character(s) ignored > > > > /home/snaga/madlib/apache-madlib-1.9.1-incubating- > > > source/src/modules/tsa/._arima.cpp:1: > > > > error: stray '\5' in program > > > > /home/snaga/madlib/apache-madlib-1.9.1-incubating- > > > source/src/modules/tsa/._arima.cpp:1: > > > > error: stray '\26' in program > > > > /home/snaga/madlib/apache-madlib-1.9.1-incubating- > > > source/src/modules/tsa/._arima.cpp:1: > > > > error: stray '\7' in program > > > > /home/snaga/madlib/apache-madlib-1.9.1-incubating- > > > source/src/modules/tsa/._arima.cpp:1:5: > > > > warning: null character(s) ignored > > > > /home/snaga/madlib/apache-madlib-1.9.1-incubating- > > > source/src/modules/tsa/._arima.cpp:1: > > > > error: stray '\2' in program > > > > /home/snaga/madlib/apache-madlib-1.9.1-incubating- > > > source/src/modules/tsa/._arima.cpp:1:7: > > > > warning: null character(s) ignored > > > > /home/snaga/madlib/apache-madlib-1.9.1-incubating- > > > source/src/modules/tsa/._arima.cpp:1:17: > > > > warning: null character(s) ignored > > > > /home/snaga/madlib/apache-madlib-1.9.1-incubating- > > > source/src/modules/tsa/._arima.cpp:1: > > > > error: stray '\2' in program > > > > /home/snaga/madlib/apache-madlib-1.9.1-incubating- > > > source/src/modules/tsa/._arima.cpp:1:27: > > > > warning: null character(s) ignored > > > > /home/snaga/madlib/apache-madlib-1.9.1-incubating- > > > source/src/modules/tsa/._arima.cpp:1:35: > > > > warning: null character(s) ignored > > > > /home/snaga/madlib/apache-madlib-1.9.1-incubating- > > > source/src/modules/tsa/._arima.cpp:1: > > > > error: stray '\260' in program > > > > /home/snaga/madlib/apache-madlib-1.9.1-incubating- > > > source/src/modules/tsa/._arima.cpp:1:39: > > > > warning: null character(s) ignored > > > > /home/snaga/madlib/apache-madlib-1.9.1-incubating- > > > source/src/modules/tsa/._arima.cpp:1: > > > > error: stray '\2' in program > > > > /home/snaga/madlib/apache-madlib-1.9.1-incubating- > > > source/src/modules/tsa/._arima.cpp:1:43: > > > > warning: null character(s) ignored > > > > /home/snaga/madlib/apache-madlib-1.9.1-incubating- > > > source/src/modules/tsa/._arima.cpp:1: > > > > error: stray '\342' in program > > > > /home/snaga/madlib/apache-madlib-1.9.1-incubating- > > > source/src/modules/tsa/._arima.cpp:1:47: > > > > warning: null character(s) ignored > > > > /home/snaga/madlib/apache-madlib-1.9.1-incubating- > > > source/src/modules/tsa/._arima.cpp:1:89: > > > > warning: null character(s) ignored > > > > /home/snaga/madlib/apache-madlib-1.9.1-incubating- > > > source/src/modules/tsa/._arima.cpp:1: > > > > error: stray '\342' in program > > > > /home/snaga/madlib/apache-madlib-1.9.1-incubating- > > > source/src/modules/tsa/._arima.cpp:1:97: > > > > warning: null character(s) ignored > > > > /home/snaga/madlib/apache-madlib-1.9.1-incubating- > > > source/src/modules/tsa/._arima.cpp:1: > > > > error: stray '\230' in program > > > > /home/snaga/madlib/apache-madlib-1.9.1-incubating- > > > source/src/modules/tsa/._arima.cpp:1:101: > > > > warning: null character(s) ignored > > > > /home/snaga/madlib/apache-madlib-1.9.1-incubating- > > > source/src/modules/tsa/._arima.cpp:1:105: > > > > warning: null character(s) ignored > > > > /home/snaga/madlib/apache-madlib-1.9.1-incubating- > > > source/src/modules/tsa/._arima.cpp:1: > > > > error: stray '\1' in program > > > > /home/snaga/madlib/apache-madlib-1.9.1-incubating- > > > source/src/modules/tsa/._arima.cpp:1:121: > > > > warning: null character(s) ignored > > > > /home/snaga/madlib/apache-madlib-1.9.1-incubating- > > > source/src/modules/tsa/._arima.cpp:1: > > > > error: stray '\230' in program > > > > /home/snaga/madlib/apache-madlib-1.9.1-incubating- > > > source/src/modules/tsa/._arima.cpp:1:125: > > > > warning: null character(s) ignored > > > > /home/snaga/madlib/apache-madlib-1.9.1-incubating- > > > source/src/modules/tsa/._arima.cpp:1:129: > > > > warning: null character(s) ignored > > > > /home/snaga/madlib/apache-madlib-1.9.1-incubating- > > > source/src/modules/tsa/._arima.cpp:1: > > > > error: stray '\25' in program > > > > /home/snaga/madlib/apache-madlib-1.9.1-incubating- > > > source/src/modules/tsa/._arima.cpp:1:152: > > > > warning: null character(s) ignored > > > > /home/snaga/madlib/apache-madlib-1.9.1-incubating- > > > source/src/modules/tsa/._arima.cpp:1:160: > > > > error: invalid suffix "c61529" on integer constant > > > > /home/snaga/madlib/apache-madlib-1.9.1-incubating- > > > source/src/modules/tsa/._arima.cpp:1: > > > > error: stray '\' in program > > > > /home/snaga/madlib/apache-madlib-1.9.1-incubating- > > > source/src/modules/tsa/._arima.cpp:1:190: > > > > error: invalid suffix "F8D3A6" on integer constant > > > > /home/snaga/madlib/apache-madlib-1.9.1-incubating- > > > source/src/modules/tsa/._arima.cpp:1:204: > > > > error: exponent has no digits > > > > /home/snaga/madlib/apache-madlib-1.9.1-incubating- > > > source/src/modules/tsa/._arima.cpp:1:209: > > > > error: invalid suffix "D0F" on integer constant > > > > /home/snaga/madlib/apache-madlib-1.9.1-incubating- > > > source/src/modules/tsa/._arima.cpp:1:226: > > > > warning: null character(s) ignored > > > > /home/snaga/madlib/apache-madlib-1.9.1-incubating- > > > source/src/modules/tsa/._arima.cpp:1: > > > > error: 'Mac' does not name a type > > > > /home/snaga/madlib/apache-madlib-1.9.1-incubating- > > > source/src/modules/tsa/._arima.cpp:1: > > > > error: expected unqualified-id before numeric constant > > > > /home/snaga/madlib/apache-madlib-1.9.1-incubating- > > > source/src/modules/tsa/._arima.cpp:1: > > > > error: 'Google' does not name a type > > > > /home/snaga/madlib/apache-madlib-1.9.1-incubating- > > > source/src/modules/tsa/._arima.cpp:1: > > > > error: expected unqualified-id before numeric constant > > > > make[2]: *** [src/ports/postgres/9.6/CMakeFiles/madlib_postgresql_ > > > 9_6.dir/__/__/__/modules/tsa/._arima.cpp.o] > > > > Error 1 > > > > make[1]: *** [src/ports/postgres/9.6/CMakeFiles/madlib_postgresql_ > > > 9_6.dir/all] > > > > Error 2 > > > > make: *** [all] Error 2 > > > > [snaga@localhost build]$ > > > > > > > > And I found that the tarball contains some binary files (?) which > > > > seems built on Mac OS X. > > > > I guess this is the reason of the build failure. > > > > > > > > [snaga@localhost madlib]$ tar ztvf > > > > apache-madlib-1.9.1-incubating-source.tar.gz | grep _arima > > > > -rw-r--r-- riyer/staff 226 2016-08-31 07:31 > > > > apache-madlib-1.9.1-incubating-source/src/ports/ > > > postgres/modules/tsa/._arima.py_in > > > > -rw-r--r-- riyer/staff 226 2016-08-31 07:31 > > > > apache-madlib-1.9.1-incubating-source/src/ports/ > > > postgres/modules/tsa/._arima.sql_in > > > > -rw-r--r-- riyer/staff 226 2016-08-31 07:31 > > > > apache-madlib-1.9.1-incubating-source/src/ports/ > > > postgres/modules/tsa/._arima_forecast.py_in > > > > -rw-r--r-- riyer/staff 226 2016-08-31 07:31 > > > > apache-madlib-1.9.1-incubating-source/src/ports/ > > > postgres/modules/tsa/test/._arima.sql_in > > > > -rw-r--r-- riyer/staff 226 2016-08-31 07:31 > > > > apache-madlib-1.9.1-incubating-source/src/ports/ > > > postgres/modules/tsa/test/._arima_train.sql_in > > > > -rw-r--r-- riyer/staff 226 2016-08-31 07:31 > > > > apache-madlib-1.9.1-incubating-source/src/modules/tsa/._arima.cpp > > > > -rw-r--r-- riyer/staff 226 2016-08-31 07:31 > > > > apache-madlib-1.9.1-incubating-source/src/modules/tsa/._arima.hpp > > > > [snaga@localhost madlib]$ file > > > > apache-madlib-1.9.1-incubating-source/src/modules/tsa/._arima.cpp > > > > apache-madlib-1.9.1-incubating-source/src/modules/tsa/._arima.cpp: > > > > AppleDouble encoded Macintosh file > > > > [snaga@localhost madlib]$ > > > > > > > > Is this intended? Or should it be fixed? > > > > > > > > Regards, > > > > > > > > > > > > 2016-09-02 4:17 GMT+09:00 Frank McQuillan <[email protected]>: > > > >> Hello MADlib community, > > > >> > > > >> We have created a MADlib 1.9.1 release candidate, with the artifacts > > > below > > > >> up for a vote. > > > >> > > > >> This will be the 3rd release for Apache MADlib (incubating). > > > >> > > > >> The main goals of this release are: > > > >> * new modules (1-class SVM for novelty detection, prediction > metrics, > > > >> sessionization, pivoting) > > > >> * improvements to existing modules (class weights in SVM, > overlapping > > > >> patterns in path) > > > >> * performance improvements (path) > > > >> * platform updates (PostgreSQL 9.5 and 9.6) > > > >> * bug fixes > > > >> * doc improvements > > > >> > > > >> For more information including release notes, please see: > > > >> https://cwiki.apache.org/confluence/display/MADLIB/MADlib+1.9.1 > > > >> > > > >> *** Please download, review and vote by Tues Sep 6, 2016 @ 6pm PST > *** > > > >> > > > >> We're voting upon the source (tag): rc/1.9.1-rc1 > > > >> > > > >> Source Files: > > > >> https://dist.apache.org/repos/dist/dev/incubator/madlib/1.9. > > > 1-incubating-rc1/ > > > >> > > > >> Commit to be voted upon: > > > >> https://git-wip-us.apache.org/repos/asf?p=incubator-madlib. > > > git;a=commit;h=e1c99c1538dc124c9b323ba76382ba2af05c6892 > > > >> > > > >> KEYS file containing PGP Keys we use to sign the release: > > > >> https://dist.apache.org/repos/dist/dev/incubator/madlib/KEYS > > > >> > > > >> To help in tallying the vote, can PMC members please be sure to > > indicate > > > >> "(binding)" with their vote. > > > >> > > > >> [ ] +1 approve > > > >> [ ] +0 no opinion > > > >> [ ] -1 disapprove (and reason why) > > > >> > > > >> Thank you, > > > >> Frank McQuillan > > > > > > > > > > > > > > > > -- > > > > Satoshi Nagayasu <[email protected]> > > > > > > > > > > > > -- > > > Satoshi Nagayasu <[email protected]> > > > > > > > > > > > -- > > > > --------------------------------------------------------- > > Rahul Iyer > > Principal software engineer | Predictive Analytics > > > > *Pivotal**A new platform for a new era* > > >
