Github user njayaram2 commented on a diff in the pull request:

    https://github.com/apache/incubator-madlib/pull/69#discussion_r81263168
  
    --- Diff: src/ports/postgres/modules/elastic_net/elastic_net.py_in ---
    @@ -369,6 +378,37 @@ def elastic_net_train(schema_madlib, tbl_source, 
tbl_result, col_dep_var,
     # ========================================================================
     
     
    +def _get_grouping_col_str(schema_madlib, source_table, grouping_col):
    +    if grouping_col and grouping_col.lower() != 'null':
    +        cols_in_tbl_valid(source_table,
    +                          _string_to_array_with_quotes(grouping_col),
    +                          'elastic_net')
    +        intersect = frozenset(
    +            _string_to_array(grouping_col)).intersection(
    +                frozenset(
    +                    ('coef', 'random_feature_data',
    +                     'random_feature_data', 'loss'
    +                     'num_rows_processed', 'num_rows_skipped',
    +                     'norm_of_gradient', 'num_iterations')))
    --- End diff --
    
    Must discuss what must go in the frozenset for elastic net.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to