Github user mktal commented on a diff in the pull request:
https://github.com/apache/incubator-madlib/pull/75#discussion_r87922862
--- Diff: src/modules/convex/algo/igd.hpp ---
@@ -86,6 +101,32 @@ IGD<State, ConstState, Task>::merge(state_type &state,
template <class State, class ConstState, class Task>
void
+IGD<State, ConstState, Task>::mergeInPlace(state_type &state,
--- End diff --
The model is updated in `StructureSVM<Model, Tuple>::gradientInPlace` and
the gradient vector is a local variable dynamically allocated on stack, hence
no need to store the gradient in the state.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
