Github user njayaram2 commented on the issue:
https://github.com/apache/incubator-madlib/pull/80
This is a great start!
I will provide some github-specific feedback here, and more knn-specific
comments in the code.
Git can be daunting to use at first, but it's great once you get a hang of
it.
I would recommend you go through the following wonderful book if you
have not already done so:
https://git-scm.com/book/en/v2
When you work on a feature/bug, it is best if you create a branch locally
and make all changes for that feature there. You can then push that branch
into your github repo and open a pull request. This way you won't mess with
your local master branch, which should ideally be in sync with the origin's
(apache/incubator-madlib in this case) master branch. More information on
how to work with branches can be found in the following chapter:
https://git-scm.com/book/en/v2/Git-Branching-Branches-in-a-Nutshell
(especially section 3.5)
One other minor feedback is to try including the corresponding JIRA id
with the commit message. The JIRA associated with this feature is:
https://issues.apache.org/jira/browse/MADLIB-927
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
