Just pushing the code should be good, you don't have to create a new pull request. The existing one will get updated.
NJ On Tue, Dec 27, 2016 at 5:56 PM, Kazmi,Auon H <aka...@ufl.edu> wrote: > Hi, > > I have been making some changes in existing KNN code after going through > the comments of Orhan. > > How should I push these changes? Should I create a new pull request and > delete the current one? > > > > Regards, > > Auon > > ________________________________ > From: auonhaidar <g...@git.apache.org> > Sent: Tuesday, December 27, 2016 3:46:09 PM > To: dev@madlib.incubator.apache.org > Subject: [GitHub] incubator-madlib pull request #81: JIRA: MADLIB-927 > Changes made in KNN-help... > > Github user auonhaidar commented on a diff in the pull request: > > https://github.com/apache/incubator-madlib/pull/81# > discussion_r93969163 > > --- Diff: src/ports/postgres/modules/knn/test/knn.sql_in --- > @@ -0,0 +1,41 @@ > +m4_include(`SQLCommon.m4') > +/* ------------------------------------------------------------ > ----------------- > + * Test knn. > + * > + * FIXME: Verify results > --- End diff -- > > You mean to say that I should include assert statements in this > test/knn.sql_in file in order to validate results, right? > > > --- > If your project is set up for it, you can reply to this email and have your > reply appear on GitHub as well. If your project does not have this feature > enabled and wishes so, or if the feature is enabled but not working, please > contact infrastructure at infrastruct...@apache.org or file a JIRA ticket > with INFRA. > --- >
