Github user decibel commented on a diff in the pull request:
https://github.com/apache/incubator-madlib/pull/89#discussion_r97462912
--- Diff: src/ports/postgres/modules/kmeans/kmeans.py_in ---
@@ -34,6 +37,25 @@ def kmeans_validate_src(schema_madlib, rel_source,
**kwargs):
# ----------------------------------------------------------------------
+def kmeans_validate_expr(schema_madlib, rel_source, expr_point, **kwargs):
+ if not columns_exist_in_table(rel_source, [expr_point]):
+
+ p = re.compile('[Aa][Rr][Rr][Aa][Yy]\s*\[\s*[\s*\w|,\s*]+\s*\]')
--- End diff --
A comment on what the regex is doing would be very helpful. The array part
is pretty obvious (though, couldn't that just be done with an insensitive
regex??), but the rest is more difficult to follow.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
