OK (Orhan Kislal), Thanks for the info (Apache ID signature preferred). That will come in handy for one of our future Apache HAWQ incubating releases.
Cheers, -=e On Thu, Feb 16, 2017 at 12:06 PM, Orhan Kislal <[email protected]> wrote: > Hi Ed, > > Thanks for the review. One of the comments from the previous release was a > preference towards a signature with an Apache id. Since Satoshi-san is not > an Apache committer yet, I took care of the signing process. > > Thanks, > > Orhan Kislal > > On Thu, Feb 16, 2017 at 11:58 AM, Ed Espino <[email protected]> wrote: > > > A few MADlib v1.10-rc1 observations from a HAWQ incubator committer. > > > > - The Copyright year (2016) in the NOTICE file needs to be updated to > > 2017. I believe this can be handled in next release. > > - As it still applies, similar to a past comment by Roman ([VOTE] > MADlib > > v1.9.1-rc2 > > <https://lists.apache.org/thread.html/981b4c24eaa2ab069b8e18f7aa4bdd > > c7a78d3a9dc26bf659af94fcfe@%3Cgeneral.incubator.apache.org%3E>) > > - *"* name of the top level folder in the archive is weird. The usual > > practice is to call the top level folder as <project name>-<version > > ID>*"* > > (example: *apache-madlib-src-1.10-incubating* instead of > > *incubator-madlib*) > > - I'm more curious than anything. Why did Orhan sign the release? I > was > > expecting the release manager (Satoshi Nagayasu) to have signed the > > release. > > - Checksums and PGP signature are good. > > - ASF headers check: I spot checked files added (git whatchanged > > --diff-filter=A) since the last release. ASF headers look good. Nice > > Job! > > > > I was going to try and build but I ran past my allotted time limit for > this > > review. Hopefully, I can try this soon. > > > > Regards, > > -=ed espino > > > > On Thu, Feb 16, 2017 at 10:05 AM, Orhan Kislal <[email protected]> > wrote: > > > > > +1 > > > > > > Orhan Kislal > > > > > > On Thu, Feb 16, 2017 at 9:23 AM, Joe Hellerstein < > > [email protected] > > > > > > > wrote: > > > > > > > +1 > > > > > > > > Sent from a telephone. > > > > > > > > > On Feb 16, 2017, at 9:17 AM, Frank McQuillan < > [email protected]> > > > > wrote: > > > > > > > > > > +1 > > > > > > > > > > Frank McQuillan > > > > > > > > > >> On Wed, Feb 15, 2017 at 7:27 PM, Satoshi Nagayasu < > [email protected]> > > > > wrote: > > > > >> > > > > >> Hello MADlib community, > > > > >> > > > > >> We have created a MADlib 1.10 RC-1, with the artifacts below up > for > > a > > > > vote. > > > > >> > > > > >> This will be the 4th release for Apache MADlib (incubating). > > > > >> > > > > >> The main goals of this release are: > > > > >> * new modules (single source shortest path for graph analytics, > > encode > > > > >> categorical variables, K-nearest neighbors) > > > > >> * improvements to existing modules (add grouping support to > elastic > > > > >> net and PCA, add cross validation to elastic net, array input for > > > > >> K-means, verbose output option for DT and RF, limit itemset size > in > > > > >> association rules, various madpack installer improvements) > > > > >> * platform updates (PostgreSQL 9.6) > > > > >> * bug fixes > > > > >> * doc improvements > > > > >> > > > > >> For more information including release notes, please see: > > > > >> https://cwiki.apache.org/confluence/display/MADLIB/MADlib+1.10 > > > > >> > > > > >> *** Please download, review and vote by Sat Feb 18, 2017 @ 6pm PST > > *** > > > > >> > > > > >> We're voting upon the source (tag): rc/1.10.0-rc1 > > > > >> https://github.com/apache/incubator-madlib/tree/rc/1.10.0-rc1 > > > > >> > > > > >> Source Files: > > > > >> https://dist.apache.org/repos/dist/dev/incubator/madlib/1. > > > > >> 10.0-incubating-rc1/ > > > > >> > > > > >> Commit to be voted upon: > > > > >> https://github.com/apache/incubator-madlib/commit/ > > > > >> ea17530bfe22a1fde173d7fa83508cbcd9924c20 > > > > >> > > > > >> KEYS file containing PGP Keys we use to sign the release: > > > > >> https://dist.apache.org/repos/dist/dev/incubator/madlib/KEYS > > > > >> > > > > >> To help in tallying the vote, can PMC members please be sure to > > > > >> indicate "(binding)" with their vote. > > > > >> > > > > >> [ ] +1 approve > > > > >> [ ] +0 no opinion > > > > >> [ ] -1 disapprove (and reason why) > > > > >> > > > > >> -- > > > > >> Satoshi Nagayasu <[email protected]> > > > > >> > > > > > > > > > > > > > > > -- > > *Ed Espino* > > *[email protected] <[email protected]>* > > > -- *Ed Espino* *[email protected] <[email protected]>*
