GitHub user iyerr3 opened a pull request:
https://github.com/apache/incubator-madlib/pull/106
Build: Fix module sort order for PGXN installation
JIRA: MADLIB-1024
PGXN installation involves creating a single extension sql file that
contains all the SQL commands run during MADlib deployment. The modules
added into this extension file are to be placed in the right order,
taking dependencies into account.
MADlib has a function that compares a given file path with topologically
sorted modules to decide the order of concatenation to extension file.
This comparison is faulty since the module name was searched for in the
whole path, leading to false positive with modules that have another
module name as substring. The specific bug was related to 'svec_util'
being flagged in same order as 'svec'.
This commit fixes this issue taking advantage of the file path names being
of the form '.../modules/<module_name>/...', hence comparing the
complete module name.
Closes #106
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/iyerr3/incubator-madlib
bugfix/module_sort_order
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-madlib/pull/106.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #106
----
commit b106e064edf5d3d03631d222a51953d0d21015d4
Author: Rahul Iyer <ri...@apache.org>
Date: 2017-02-24T22:32:32Z
Build: Fix module sort order for PGXN installation
JIRA: MADLIB-1024
PGXN installation involves creating a single extension sql file that
contains all the SQL commands run during MADlib deployment. The modules
added into this extension file are to be placed in the right order,
taking dependencies into account.
MADlib has a function that compares a given file path with topologically
sorted modules to decide the order of concatenation to extension file.
This comparison is faulty since the module name was searched for in the
whole path, leading to false positive with modules that have another
module name as substring. The specific bug was related to 'svec_util'
being flagged in same order as 'svec'.
This commit fixes this issue taking advantage of the file path names being
of the form '.../modules/<module_name>/...', hence comparing the
complete module name.
Closes #106
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
