Github user orhankislal commented on a diff in the pull request:

    https://github.com/apache/incubator-madlib/pull/162#discussion_r132541348
  
    --- Diff: src/ports/postgres/modules/convex/test/mlp.sql_in ---
    @@ -241,9 +247,8 @@ SELECT mlp_predict(
     
     select * from mlp_prediction;
     SELECT assert(
    -    -- Accuracy greater than 90%
    -    COUNT(*)/150.0 > 0.95,
    -    'MLP: Accuracy is too low (< 95%). Wrong result.'
    +    COUNT(*)/150.0 > 0.99,
    --- End diff --
    
    Tested on PG 9.4 and the latest commit of GPDB 5 (1 node, 3 segments).
    IC passes on Postgres but fails on GPDB5. I tested the code manually and it 
works fine with 148/150 accuracy. I would suggest dropping the assertion 
threshold to 95% to make sure such minute changes do not fail the whole test.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to