There are arguments in both directions. In my view, the ideal is: 1) declare a target date. 2) everyone clears the deck of patches. 3) Reformat
Grant's proposal, which goes 1) have a reason to modify some particular bit 2) check in patch 3) check in reformat before someone else starts a patch is not bad, either. On Sat, May 29, 2010 at 1:30 PM, Grant Ingersoll <[email protected]>wrote: > > On May 29, 2010, at 11:11 AM, Robin Anil wrote: > > > Math module clearly doesn't conform to the style guidelines. Does it > > make sense to go and clean it entirely or should we do it for the ones > > we use, when we use it? > > > > > > I'm not a big fan of massive formatting changes. It breaks a lot of > otherwise good patches. I usually apply them right as I'm about to commit > on the files I have open. > > -Grant
