[
https://issues.apache.org/jira/browse/MAHOUT-409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12875349#action_12875349
]
Sean Owen commented on MAHOUT-409:
----------------------------------
Yeah 'inProgress' can at best be a volatile boolean, if it were ever used as a
'done' flag in a multi-threaded situation, but doesn't seem so. It can just be
a boolean, no sync.
The Comparator issues... well Comparators are typically Serializable for good
measure since they are often packaged into Collection implementations, which
are Serializable, and so must be as well. But it's right, the Hadoop Comparator
they extend isn't serialization-friendly so just make the subclasses
unserializable.
The clone() issue is actually not an issue.
The mutable array thing is easily addressed, if we want to shut it up, with an
unmodifiable LIst. It's not actually an issue.
The floating-point issues are as well all non-issues, actually.
> Find bugs finds some bugs in our code
> -------------------------------------
>
> Key: MAHOUT-409
> URL: https://issues.apache.org/jira/browse/MAHOUT-409
> Project: Mahout
> Issue Type: Bug
> Reporter: Ted Dunning
> Attachments: MAHOUT-409.patch
>
>
> I will produce a patch shortly that fixes some low hanging fruit highlighted
> by findbugs.
> Notably this:
> http://hudson.zones.apache.org/hudson/job/Mahout-Quality/48/findbugsResult/HIGH/type.-1824009442/source.8285/#44
> and
> http://hudson.zones.apache.org/hudson/job/Mahout-Quality/48/findbugsResult/HIGH/type.-694648638/
> and
> http://hudson.zones.apache.org/hudson/job/Mahout-Quality/48/findbugsResult/HIGH/type.-1787470473/
> and
> http://hudson.zones.apache.org/hudson/job/Mahout-Quality/48/findbugsResult/HIGH/type.921339475/
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
