one more thing I noticed. from line 457-484, the whole stuff could be removed, since you are working with fresh data, so those situations don't really apply, I think
On Mon, Jun 28, 2010 at 8:23 PM, Sean Owen <[email protected]> wrote: > Yah good one, that looks wrong. I will fix that now (and I think a > similar problem later in the file.) > > On Sun, Jun 27, 2010 at 11:41 PM, Tamas Jambor <[email protected]> wrote: > > hi Sean, > > > > I might have spotted a bug in FileDataModel, in line 444, you create a > > PreferenceArray newPrefs and then shift the existing values one step > down, > > but in the end this updated object never gets written back to the main > data > > object. > > > > Tamas > > >
