I think we might be battling inadvertently in SVN -- I think you undid my last change and a bit more. Not a problem per se but let's discuss what the thing to do is.
I think the output of the jobs ought to not depend on the Locale. While it may be "internally consistent" to use the system default Locale in all instances, since input and output will match for one user, it means that it won't match when two users trade data and are using different Locales. This seems Surprising, and was the nature of the original 'bug' we were trying to fix, where the tests failed on golden data for this reason. I went a bit overboard in the name of consistency and made some *log* statements fixed at Locale.ENGLISH for consistency (and removed use of String.format() where it didn't do anything beyond what Logger does). That I don't mind un-doing. But I think we really want the bits that serialize data as a String to be deterministic? On Wed, Aug 18, 2010 at 2:23 PM, Ted Dunning <[email protected]> wrote: > I was just grabbing for a nice big hammer that I could be sure would work. > Happy to back it off a bit. > > On Tue, Aug 17, 2010 at 11:51 PM, Sean Owen <[email protected]> wrote: > >> Where this had happened before we just used the "Locale.ENGLISH" >> locale as a slightly more neutral alternative. Is that OK? >> >> On Wed, Aug 18, 2010 at 12:07 AM, Sebastian Schelter <[email protected]> >> wrote: >> > Yes, everything's fine now, thanks for the quick response. >> > >> > Am 18.08.2010 00:54, schrieb Ted Dunning: >> >> Sebastian, >> >> >> >> I just committed a fix. I tested it by setting the locale to DE.de and >> got >> >> the expected failure. That implies that >> >> the fix should make things good for you. >> >
