I agree that final statics should be marked using UPPER CASE, but these
variables aren't necessary going to stay final.

So the reversion was removing final AND switching back to lower case.

On Tue, Sep 28, 2010 at 8:10 AM, Sean Owen <[email protected]> wrote:

> Out of curiosity why was this reverted? The motivation seems to be
> avoiding warnings but the original change was to avoid warnings.
>
>
> http://svn.apache.org/viewvc/mahout/trunk/examples/src/main/java/org/apache/mahout/classifier/sgd/TrainNewsGroups.java?root=Apache-SVN&r1=1002032&r2=1002033
>
> I don't mind instead removing the CONSTANTS_ARE_CAPS inspection rule
> (where constants are broadly anything static and final), though that's
> pretty conventional in Java.
>

Reply via email to