Cool. Go ahead, will commit soon after your patch is done.

On Wed, Oct 6, 2010 at 1:33 AM, Ted Dunning <[email protected]> wrote:

> I have some small problems with the changes.
>
> I think that the same result can be had using inheritance more.  For
> instance, the based IDF text encoder should only over-ride the flush
> method,
> not duplicate the other methods.  I have a tangle in my source code right
> now, but I will try to put up a response patch
> shortly.
>
> On Tue, Oct 5, 2010 at 12:48 PM, Robin Anil <[email protected]> wrote:
>
> > Take a look at the two patches. If they are worthy for this release.
> > Otherwise I will commit them after the RC gets cut
> >
> > RObin
> >
> >
> > On Wed, Oct 6, 2010 at 12:45 AM, Ted Dunning <[email protected]>
> > wrote:
> >
> > > +1
> > >
> > > We should cut an RC branch soonest so that trunk commits can continue.
> > >
> > > On Tue, Oct 5, 2010 at 1:41 AM, Sean Owen <[email protected]> wrote:
> > >
> > > > MAHOUT-287 and MAHOUT-521 are left for 0.4. We had talked about
> > starting
> > > > the
> > > > release process from this morning. What's the ETA on wrapping these
> up?
> > > >
> > > > I'd suggest we all try to start that process of review, polish,
> testing
> > > we
> > > > had planned anyway and save any non-essential changes for the moment.
> > > Cool?
> > > >
> > >
> >
>

Reply via email to