[ 
https://issues.apache.org/jira/browse/MAHOUT-520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12920422#action_12920422
 ] 

Drew Farris commented on MAHOUT-520:
------------------------------------

Joe, The attached patch looks good, I noticed that :

{code}
if [ $1 = "-ni" ]; then
{code}

Should likely be:

{code}
if [ "$1" = "-ni" ]; then
{code}

So an error isn't emitted if $1 isn't present.

I'm also wondering about the blind -rmr of a directory named 'testdata' 
although I do something similar in the 20newsgroups script. Perhaps in this 
case we should test for the presence of the directory we're about to delete and 
exit if it already exists? Alternatively it may be ok if we name the directory 
something to be fairly sure that I won't exist, e,g: 
examples/bin/work/20news-bydate/bayes-test-input may be pretty safe.

Regardless, I ran the canopy, kmeans and fuzzykmeans algorithms from the script 
in interactive mode and they appeared to execute correctly.




> Add example scripts / integration tests for various algorithms.
> ---------------------------------------------------------------
>
>                 Key: MAHOUT-520
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-520
>             Project: Mahout
>          Issue Type: Improvement
>          Components: Classification
>    Affects Versions: 0.4
>            Reporter: Drew Farris
>            Assignee: Drew Farris
>            Priority: Minor
>         Attachments: MAHOUT-520-syntheticcontrol.patch, MAHOUT-520.patch
>
>
> Scripts like build-reuters.sh are useful in that they both demonstrate 
> typical usage of Mahout from the command-line but also serve as integration 
> tests. We should add additional scripts that drive the algorithms so new 
> users can quickly run the examples. 
> Perhaps these can also be run from hudson as a part of the nightly builds and 
> can serve as integration tests.
> As a start towards this goal, provide build-20news-bayes.sh example (in the 
> same vein as build-reuters.sh, that follows 
> https://cwiki.apache.org/MAHOUT/twenty-newsgroups.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to