[
https://issues.apache.org/jira/browse/MAHOUT-565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12972037#action_12972037
]
Sean Owen commented on MAHOUT-565:
----------------------------------
I looked at the patch and might be missing something but i don't see how it
changes the behavior. After the shift, the cast to byte retains only the bottom
8 bits anyway. The shifted-in bits don't matter right?
The formatting changes are fine IMHO.
There are several other changes in this patch, is that intended?
And might they be affecting or even fixing whatever you observe?
> Features incorrectly hashed in Minhash
> --------------------------------------
>
> Key: MAHOUT-565
> URL: https://issues.apache.org/jira/browse/MAHOUT-565
> Project: Mahout
> Issue Type: Bug
> Affects Versions: 0.4
> Reporter: Ankur
> Assignee: Ankur
> Attachments: jira-565.v1.patch
>
>
> Given a feature vector for which minhash signature is desired, each feature
> id (an integer) is converted to a byte array through a series of bit shift
> operations. Current implementation of these operations doesn't mask the bits
> being shifted resulting in sign bit being shifted.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
