Got it. thanks. So patch should be submitted thru 'submit patch', not as attachment . I remember trying that but firefox did not show 'browse for file' button for some reason so i went for attachment.
Sorry for confusion. -d On Mon, Jan 24, 2011 at 4:43 PM, Ted Dunning <[email protected]> wrote: > There is a Patch Available state that you can get to by clicking on "Submit > Patch". > > Then when the patch is committed, the committer will resolve the issue and > when the next release happens, the issue will be closed. > > On Mon, Jan 24, 2011 at 4:33 PM, Dmitriy Lyubimov <[email protected]> > wrote: > > > Thank you, Sean. > > > > That's what i am saying . I did not understand the flow, perhaps i > > shouldn't > > have resolved it. In the companies i worked they usually marked issues as > > 'resolved' to indicate that development solution is available. Once it is > > verified (and integrated, if necessary), it is closed. Or reopened to > > indicate that more development work is needed. I just got confused here a > > little. > > > > Whatever it is, it's by all means fine, I just need to understand the > > convention. I will leave it open in the future. > > > > (I guess the only question is then how i would indicate that i am done > > developing patch for it (other than submitting a patch) and think it is > > good > > to go? Just put a free-form comment? If so, then there's no way to build > a > > jira view for 'ready-for-review' stuff then). > > > > Thanks. > > > > -d > > > > > > > > On Mon, Jan 24, 2011 at 4:12 PM, Sean Owen (JIRA) <[email protected]> > wrote: > > > > > > > > [ > > > > > > https://issues.apache.org/jira/browse/MAHOUT-587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12986119#action_12986119 > > ] > > > > > > Sean Owen commented on MAHOUT-587: > > > ---------------------------------- > > > > > > You resolved your own issue though, it seems, so you indicated that it > > was > > > not a problem anymore. I'm not sure I understand. > > > > > > > -Dmapred.job.queue.name=unfunded is not counted in for seq2sparse > > > > ----------------------------------------------------------------- > > > > > > > > Key: MAHOUT-587 > > > > URL: > https://issues.apache.org/jira/browse/MAHOUT-587 > > > > Project: Mahout > > > > Issue Type: Bug > > > > Components: Utils > > > > Affects Versions: 0.4 > > > > Environment: RHL Linux 2.6.18 x86_64 > > > > Reporter: Shige Takeda > > > > Assignee: Sean Owen > > > > Priority: Minor > > > > Fix For: 0.5 > > > > > > > > Attachments: 0001-added-D-option-support-to-seq2sparse.patch > > > > > > > > > > > > I revisited this and found the -D problem still remains in > > seq2sparse... > > > > $ $MAHOUT_HOME/bin/mahout seq2sparse --input text_output --output > > > seq_output -Dmapred.job.queue.name=unfunded > > > > Running on hadoop, using HADOOP_HOME=/grid/0/gs/hadoop/current > > > > HADOOP_CONF_DIR=/grid/0/gs/conf/current > > > > 11/01/21 20:12:39 ERROR vectorizer.SparseVectorsFromSequenceFiles: > > > Exception > > > > org.apache.commons.cli2.OptionException: Unexpected - > > > Dmapred.job.queue.name=unfunded while processing Options > > > > at > > org.apache.commons.cli2.commandline.Parser.parse(Parser.java:99) > > > > at > > > > > > org.apache.mahout.vectorizer.SparseVectorsFromSequenceFiles.main(SparseVectorsFromSequenceFiles.java:137) > > > > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > > > > at > > > > > > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) > > > > at > > > > > > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) > > > > at java.lang.reflect.Method.invoke(Method.java:597) > > > > at > > > > > > org.apache.hadoop.util.ProgramDriver$ProgramDescription.invoke(ProgramDriver.java:68) > > > > at > > > org.apache.hadoop.util.ProgramDriver.driver(ProgramDriver.java:139) > > > > at > > > org.apache.mahout.driver.MahoutDriver.main(MahoutDriver.java:174) > > > > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > > > > at > > > > > > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) > > > > at > > > > > > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) > > > > at java.lang.reflect.Method.invoke(Method.java:597) > > > > at org.apache.hadoop.util.RunJar.main(RunJar.java:156) > > > > Usage: > > > > ... > > > > The cause is obvious; as somebody mentioned (as well as I see from > > source > > > code), > > > > > > ./core/src/main/java/org/apache/mahout/vectorizer/SparseVectorsFromSequenceFiles.java > > > doesn't use ToolRunner, and an appropriate propagation of config object > > to > > > MR jobs is missing. > > > > Although this may be a known issue, since it is not filed in JIRA, > I've > > > done just in case. > > > > > > -- > > > This message is automatically generated by JIRA. > > > - > > > You can reply to this email to add a comment to the issue online. > > > > > > > > >
