[
https://issues.apache.org/jira/browse/MAHOUT-593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13001127#comment-13001127
]
Dmitriy Lyubimov edited comment on MAHOUT-593 at 3/1/11 9:42 PM:
-----------------------------------------------------------------
Ok... should it get more support before i commit or i may commit now?
I looked at IOUtils, it seems it has quiet close methods which i can't use
directly. I actually need a noisy close (as close is semantic equivalent of
transaction confirmation in a way) so the idea here is to propagate an error
after making sure all resources are released still.
so I think i still need closeAll() method in the form it exists (albeit it
perhaps may be changed to be more inline with existing names -- i don't have an
opinion on that. ) Another piece of functionality is that it removes closeable
from the collection after resource is closed in order to prevent repeating
close attempts on something that has been closed (and also release the java
ref). And another piece is that it observes the order of releases as per
collection order. None of those features is supported by existing quiet close
methods in IOUtils.
So i think i am ready to commit then, no more patches for this issue.
was (Author: dlyubimov2):
Ok... should it get more support before i commit or i may commit now?
I looked at IOUtils, it seems it has quiet close methods which i can't use
directly. I actually need a noisy close (as close is semantic equivalent of
transaction confirmation in a way) so the idea here is to propagate an error
after making sure all resources are released still.
so I think i still need closeAll() method in the form it exists (albeit it
perhaps may be changed to be more inline with existing names -- i don't have an
opinion on that. ) Another piece of functionality is that it removes closeable
from the collection after resource is closed repeating close attempts on
something that has been closed (and also release the java ref). And another
piece is that it observes the order of releases as per collection order. None
of those features is supported by existing quiet close methods in IOUtils.
So i think i am ready to commit then, no more patches for this issue.
> Backport of Stochastic SVD patch (Mahout-376) to hadoop 0.20 to ensure
> compatibility with current Mahout dependencies.
> ----------------------------------------------------------------------------------------------------------------------
>
> Key: MAHOUT-593
> URL: https://issues.apache.org/jira/browse/MAHOUT-593
> Project: Mahout
> Issue Type: New Feature
> Components: Math
> Affects Versions: 0.4
> Reporter: Dmitriy Lyubimov
> Fix For: 0.5
>
> Attachments: MAHOUT-593.patch.gz, MAHOUT-593.patch.gz,
> MAHOUT-593.patch.gz, SSVD-givens-CLI.pdf, ssvdclassdiag.png
>
>
> Current Mahout-376 patch requries 'new' hadoop API. Certain elements of that
> API (namely, multiple outputs) are not available in standard hadoop 0.20.2
> release. As such, that may work only with either CDH or 0.21 distributions.
> In order to bring it into sync with current Mahout dependencies, a backport
> of the patch to 'old' API is needed.
> Also, some work is needed to resolve math dependencies. Existing patch relies
> on apache commons-math 2.1 for eigen decomposition of small matrices. This
> dependency is not currently set up in the mahout core. So, certain snippets
> of code are either required to go to mahout-math or use Colt eigen
> decompositon (last time i tried, my results were mixed with that one. It
> seems to produce results inconsistent with those from mahout-math
> eigensolver, at the very least, it doesn't produce singular values in sorted
> order).
> So this patch is mainly moing some Mahout-376 code around.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
