The Eclipse settings of my work editor are different than the Mahout conventions. I haven't heard any more feedback on the meat of this issue but have no problem committing it. I will take a look this weekend and make a disposition.
-----Original Message----- From: Sean Owen (JIRA) [mailto:[email protected]] Sent: Sunday, March 20, 2011 1:50 PM To: [email protected] Subject: [jira] [Commented] (MAHOUT-626) T1 and T2 Values in Canopy (& MeanShift) [ https://issues.apache.org/jira/browse/MAHOUT-626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13008967#comment-13008967 ] Sean Owen commented on MAHOUT-626: ---------------------------------- Jeff I glanced at it and didn't see any issues except formatting. A lot of the changed lines look like whitespace changes, and it seems to be using tabs for indents vs 2 spaces. (I'd also suggested that private fields plus protected getters are better than protected fields.) But we can address it later. I think you are in the best position to understand this code and the need and the change, so it seems reasonable enough for you to perhaps look at the above and then commit and if there are any small further changes you can iterate from there. > T1 and T2 Values in Canopy (& MeanShift) > ----------------------------------------- > > Key: MAHOUT-626 > URL: https://issues.apache.org/jira/browse/MAHOUT-626 > Project: Mahout > Issue Type: Improvement > Components: Clustering > Affects Versions: 0.5 > Reporter: Jeff Eastman > Assignee: Jeff Eastman > Fix For: 0.5 > > Attachments: CanopyT3T4.patch > > > Users are reporting that the T1 and T2 threshold values which work in > sequential mode don't work as well in the mapreduce mode because both the > mapper and reducer are using the same values. The effect of coalescing a > number of points into a single centroid done by the mapper changes the > distances enough that independent threshold values are needed in the reducer. > Here is a patch which implements optional T3 and T4 threshold values which > are only used by the canopy reducer. Convenience methods have been added for > API compatibility and defaults included so that these values will default to > T1 and T2. A new unit test confirms the thresholds are being set correctly. > If this works out as a positive improvement, I will make the same changes to > MeanShift and commit them -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
